Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Dataset ID row to the Main information (KeyInfo) summary list on the consumer dataset “About this dataset” tab, using the existing shared view component and bilingual i18n keys. The row is conditionally rendered so pages without a datasetId continue to work without changes.
Changes:
- Render a new “Dataset ID” summary-list row in
KeyInfowhenprops.datasetIdis present. - Add new i18n keys for the label in English and Welsh.
- Extend the consumer
AboutTabprops to accept an optionaldatasetId(and forward it via prop spreading).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/shared/views/components/dataset/KeyInfo.jsx | Conditionally renders a new summary-list row showing datasetId. |
| src/shared/i18n/en.json | Adds English translation for the new “Dataset ID” label key. |
| src/shared/i18n/cy.json | Adds Welsh translation for the new “Dataset ID” label key. |
| src/consumer/views/dataset/components/AboutTab.tsx | Adds optional datasetId to props (forwarded into KeyInfo via {...props}). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeyInfo) section on the About this dataset tab in the consumer view"Dataset ID"(EN) /"ID y set ddata"(CY)props.datasetIdso it degrades gracefully if the value is absentTest plan